Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Time Tower usage warnings sending excessively #2751

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Fix: Time Tower usage warnings sending excessively #2751

merged 5 commits into from
Oct 18, 2024
+5 −5

Conversation

MTOnline69
Copy link
Contributor

@MTOnline69 MTOnline69 commented Oct 17, 2024 •
edited
Loading

What

Fixes two issues with the Time Tower Usage Warning:

  • sending a message for 0 charges being available when joining skyblock (reported here)
  • sending after tower expiry (shouldn't happen since the Expiry Reminder is meant for this)

Changelog Fixes

  • Fixed the Time Tower Usage Warning notifying you after an expiry or about having 0 charges. - MTOnline

@github-actions github-actions bot added the Bug Fix Bug fixes label Oct 17, 2024
@MTOnline69 MTOnline69 changed the title Fix: Time Tower notifying about 0 charges available Fix: Time Tower notification about 0 charges available Oct 17, 2024
@MTOnline69 MTOnline69 marked this pull request as draft October 17, 2024 15:40
@MTOnline69 MTOnline69 marked this pull request as ready for review October 17, 2024 18:28
@MTOnline69 MTOnline69 changed the title Fix: Time Tower notification about 0 charges available Fix: Time Tower usage warnings sending excessively Oct 17, 2024
@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Oct 17, 2024
@CalMWolfs CalMWolfs added this to the Version 0.28 milestone Oct 17, 2024
@hannibal002 hannibal002 merged commit 33a9608 into hannibal002:beta Oct 18, 2024
6 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Bug Fix Bug fixes labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs CalMWolfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
3 participants
@MTOnline69 @CalMWolfs @hannibal002