Backend: Fix code in PlayerChatManager #2756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMWolfs
added
the
Soon
github-actions
bot
added
the
Backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code checks if SystemMessageEvent or AbstractChatEvent is cancelled and then tries to cancel LorenzChatEvent if they are cancelled.
But none of these 3 events are cancellable and would throw an error when they are attempted to be cancelled. As far as i could see, SystemMessageEvent and AbstractChatEvent are never actually attempted to be cancelled and only are blocked (like they should be)
exclude_from_changelog