Backend: TickEvent repeatSeconds Deprecation #3098
Open
+38
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: J10a1n15 <[email protected]>
github-actions
bot
added
the
Backend
Signed-off-by: J10a1n15 <[email protected]>
One or more Detekt Failures were detected:
|
Signed-off-by: J10a1n15 <[email protected]>
jani270
added
the
Soon
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
One or more Detekt Failures were detected:
|
Signed-off-by: J10a1n15 <[email protected]>
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/nether/SulphurSkitterBox.kt
Signed-off-by: J10a1n15 <[email protected]>
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/bingo/card/nextstephelper/BingoNextStepHelper.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/rift/area/wyldwoods/RiftLarva.kt # src/main/java/at/hannibal2/skyhanni/features/rift/area/wyldwoods/RiftOdonata.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
added
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/bingo/card/nextstephelper/BingoNextStepHelper.kt # src/main/java/at/hannibal2/skyhanni/features/nether/SulphurSkitterBox.kt # src/main/java/at/hannibal2/skyhanni/features/rift/area/wyldwoods/RiftLarva.kt # src/main/java/at/hannibal2/skyhanni/features/rift/area/wyldwoods/RiftOdonata.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
One or more Detekt Failures were detected:
|
Signed-off-by: J10a1n15 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I kinda feel like repeatSeconds should have its @Deprecation (oops, hi 👋) removed.I did that, pls feedbackIn some cases, like in the screenshot below the repeatSeconds event is better to look at.
In some rare cases using this is 100% better
The Ordanata/Larva changes might seem weird at first, but the main method alr ran every second, and the other variables had no other use cases so this should be fine.
Keeps the .repeatSeconds in the Reputation Helper since this one should be resolved by "removing" TablistUtils.getTablist()Done by #3207Changelog Technical Details