Improvement: garden keybinds

[Cedric-Ab]

What

You can now set 5 keybind layouts, each with different keybinds.
You can then for each crop select what layout you'd wish to use.
Also moved it into it's own category

Images

Changelog Improvements

• Improved garden keybinds. - Cédric Ab
  • Now set up to 5 different keybind layouts to choose from with each crop.

[github-actions]

One or more Detekt Failures were detected:

• GardenCustomKeybinds.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
• GardenCustomKeybinds.kt#L125: Unnecessary long whitespace
• GardenCustomKeybinds.kt#L141: Unnecessary long whitespace
• GardenCustomKeybinds.kt#L19: Unused import
• GardenCustomKeybinds.kt#L102: Used in this way a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty.
• GardenCustomKeybinds.kt#L35: Variable 'layouts' could be val.
• GardenCustomKeybinds.kt#L89: Variable 'allKeybindings' could be val.

[github-actions]

One or more Detekt Failures were detected:

• GardenCustomKeybinds.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
• GardenCustomKeybinds.kt#L125: Unnecessary long whitespace
• GardenCustomKeybinds.kt#L141: Unnecessary long whitespace
• GardenCustomKeybinds.kt#L19: Unused import
• GardenCustomKeybinds.kt#L102: Used in this way a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty.
• GardenCustomKeybinds.kt#L35: Variable 'layouts' could be val.
• GardenCustomKeybinds.kt#L89: Variable 'allKeybindings' could be val.

[Cedric-Ab]

@Thunderblade73
would it be better to use stuff like getting all the variables in the config to then dynamically do the stuff. so you could just adjust the number of layouts in config and then the kotlin would automatically just work with the amount of layouts in the config?
My main concern with this is the unneeded complexity this would generate

[github-actions]

One or more Detekt Failures were detected:

• GardenCustomKeybinds.kt#L96: Missing newline before ")"
• GardenCustomKeybinds.kt#L93: Used in this way a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty.

[github-actions]

One or more Detekt Failures were detected:

• GardenCustomKeybinds.kt#L93: Used in this way a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty.

[Thunderblade73]

@Thunderblade73 would it be better to use stuff like getting all the variables in the config to then dynamically do the stuff. so you could just adjust the number of layouts in config and then the kotlin would automatically just work with the amount of layouts in the config? My main concern with this is the unneeded complexity this would generate

Yeah that would be better imo. If done correctly it should reduce complexity and not add more (as far as I can tell).
Also if you want to give the layout enum more functionallity I would suggest to move it to kotlin, since java code gets more cluttered and the config supports kotlin enums.

Btw. enums have a way to get all entries .values (for java) and .entries for kotlin (before the dot is the Enum Type)

[github-actions]

One or more Detekt Failures were detected:

• GardenCustomKeybinds.kt#L107: Used in this way a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty.

[Cedric-Ab]

@Thunderblade73 would it be better to use stuff like getting all the variables in the config to then dynamically do the stuff. so you could just adjust the number of layouts in config and then the kotlin would automatically just work with the amount of layouts in the config? My main concern with this is the unneeded complexity this would generate

Yeah that would be better imo. If done correctly it should reduce complexity and not add more (as far as I can tell). Also if you want to give the layout enum more functionallity I would suggest to move it to kotlin, since java code gets more cluttered and the config supports kotlin enums.

Btw. enums have a way to get all entries .values (for java) and .entries for kotlin (before the dot is the Enum Type)

do you think I could replace the map: layouts with the enum?
and would it need to be in kotlin or could it stay in java?

[Thunderblade73]

do you think I could replace the map: layouts with the enum? and would it need to be in kotlin or could it stay in java?

Yes, you can replace the map.
The can stay in java yes, but makeing them in kotlin is easier.

[Cedric-Ab]

TODO: move GardenCustomKeybinds.kt into keybinds

[Cedric-Ab]

@Thunderblade73
Is cropLayoutSelection initialized on startup?
is configloadevent called on startup?

[Thunderblade73]

@Thunderblade73 Is cropLayoutSelection initialized on startup? is configloadevent called on startup?

It is loaded via Gson at ConfigLoadEvent (or what ever it is called) or if no value is present in the config json than it calls the constructor.

[Cedric-Ab]

@Thunderblade73 Is cropLayoutSelection initialized on startup? is configloadevent called on startup?

It is loaded via Gson at ConfigLoadEvent (or what ever it is called) or if no value is present in the config json than it calls the constructor.

The cropLayoutSelection is a map inside of the kotlin, you got that like this, right?

[Thunderblade73]

The cropLayoutSelection is a map inside of the kotlin, you got that like this, right?

Nope, I saw the value in KeyBindConfig and assume you where referencing it,

[Cedric-Ab]

The cropLayoutSelection is a map inside of the kotlin, you got that like this, right?

Nope, I saw the value in KeyBindConfig and assume you where referencing it,

So is ConfigLoadEvent called upon launch?

[Thunderblade73]

is configloadevent called on startup?

yes

Is cropLayoutSelection initialized on startup?

Yes, but you override it every update().
Btw. it does not need to exist since you can simply add a extension function to CropType that gets the value from an when since it does not compute anything since the getLayoutByDisplayName(something.toString()) is redundant because something is already a Layout

[Cedric-Ab]

is configloadevent called on startup?

yes

Is cropLayoutSelection initialized on startup?

Yes, but you override it every update(). Btw. it does not need to exist since you can simply add a extension function to CropType that gets the value from an when since it does not compute anything since the getLayoutByDisplayName(something.toString()) is redundant because something is already a Layout

Yes, I see
This is a thing that needs to be done

TODO

[github-actions]

One or more Detekt Failures were detected:

• GardenCustomKeybinds.kt#L6: Unused import
• GardenCustomKeybinds.kt#L9: Unused import
• GardenCustomKeybinds.kt#L18: Unused import

[github-actions]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[github-actions]

Conflicts have been resolved! 🎉

[github-actions]

One or more Detekt Failures were detected:

• GardenCustomKeybinds.kt#L53: Missing spacing before "?:"

[Cedric-Ab]

TODO:

• Move GardenCustomKeybinds.kt into keybinds

[github-actions]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.