Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Module Restructure #3149

Draft
wants to merge 5 commits into
base: beta
Choose a base branch
from

Conversation

lunaynx
Copy link
Contributor

@lunaynx lunaynx commented Jan 2, 2025

What

Restructured modules to all be objects and be loadable using @SkyHanniModule.

Dependencies

#3162 (waiting on this due to conflicts)

Changelog Technical Details

  • Restructured a few outlier modules to standard format. - Luna

@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Jan 2, 2025
@lunaynx lunaynx changed the title Backend: Module Restructure & /shreloadlisteners Fix Backend: Module Restructure Jan 5, 2025
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

Copy link

github-actions bot commented Jan 7, 2025

Conflicts have been resolved! 🎉

@github-actions github-actions bot added Merge Conflicts There are open merge conflicts with the beta branch. and removed Merge Conflicts There are open merge conflicts with the beta branch. labels Jan 7, 2025
Copy link

github-actions bot commented Jan 8, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Conflicts have been resolved! 🎉

Copy link

github-actions bot commented Jan 8, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 8, 2025
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Detekt Has detekt problem label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

One or more Detekt Failures were detected:

  • LoadedModules.kt#L3: Class LoadedModules is too large. Consider splitting it into smaller pieces.

@github-actions github-actions bot removed the Detekt Has detekt problem label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend A backend pull request that will be merged soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant