Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Custom user sounds for Inquisitor waypoint sharing #3160

Open
wants to merge 14 commits into
base: beta
Choose a base branch
from

Conversation

KeinsWolfi
Copy link
Contributor

@KeinsWolfi KeinsWolfi commented Jan 5, 2025

  • Added a Soundconfig for Inquisitor waypoint sharing

What

Added a SoundConfig to allow the user to set a custom sound for when an Inquisitor is found

Changelog New Features

  • Added a SoundConfig to allow the user to set custom Inquisitor found Sounds. - Helium9

+ Added a Soundconfig for Inquisitor waypoint sharing
@KeinsWolfi
Copy link
Contributor Author

Let me know if you want anything changed/added/removed, need to still test in-game though as this is only a quick draft

@KeinsWolfi KeinsWolfi marked this pull request as ready for review January 7, 2025 18:25
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

I have detected some issues with your pull request:

Body issues:
Change should start with 'Added' instead of 'Add' in text: Adds a SoundConfig to allow the user to set custom Inquisitor found Sounds.

Please fix these issues. For the correct format, refer to the pull request template.

1 similar comment
Copy link

github-actions bot commented Jan 7, 2025

I have detected some issues with your pull request:

Body issues:
Change should start with 'Added' instead of 'Add' in text: Adds a SoundConfig to allow the user to set custom Inquisitor found Sounds.

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Jan 7, 2025
@hannibal002 hannibal002 added this to the Version 2.0.0 milestone Jan 8, 2025
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jan 11, 2025
@github-actions github-actions bot added the Detekt Has detekt problem label Jan 11, 2025
Copy link

One or more Detekt Failures were detected:

@KeinsWolfi
Copy link
Contributor Author

Grrr

Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Jan 11, 2025
@KeinsWolfi KeinsWolfi requested a review from CalMWolfs January 11, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Soon This Pull Request will be merged within the next couple of betas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants