Improvement: Open Last Storage now saves across instances #3182
+65
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One or more Detekt Failures were detected:
|
j10a1n15
reviewed
Jan 8, 2025
src/main/java/at/hannibal2/skyhanni/features/commands/OpenLastStorage.kt
Outdated
Show resolved
Hide resolved
|
Should be ready for review, will test more tomorrow though (at least I hope so as Physics exam on friday 😭) |
github-actions
bot
added
the
Wrong Title/Changelog
|
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
github-actions
bot
removed
the
Wrong Title/Changelog
j10a1n15
suggested changes
Jan 8, 2025
src/main/java/at/hannibal2/skyhanni/config/features/misc/MiscConfig.java
Show resolved
Hide resolved
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
github-actions
bot
added
Detekt
|
Ready to merge, tested and works really good |
CalMWolfs
requested changes
Jan 10, 2025
src/main/java/at/hannibal2/skyhanni/config/features/misc/LastStorageConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/commands/OpenLastStorage.kt
Outdated
Show resolved
Hide resolved
CalMWolfs
requested changes
Jan 10, 2025
src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.kt
Outdated
Show resolved
Hide resolved
One or more Detekt Failures were detected:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improves Open Last Storage to now save across instances
Changelog Improvements