Change for with no lead #3190

AuroZed · 2025-01-09T19:17:31Z

Dependencies

Backend: Base Stats #3197

What

A few changes and tries that doesnt really work in the end :D

github-actions · 2025-01-09T19:19:26Z

I have detected some issues with your pull request:

Body issues:
Author is not set in text: + Cool new feature. - your_name_here
Extra info is not filled out in text: * Extra info.
Author is not set in text: + Improved cool feature. - your_name_here
Extra info is not filled out in text: * Extra info.
Author is not set in text: + Fixed cool feature. - your_name_here
Extra info is not filled out in text: * Extra info.
Author is not set in text: + Something technical you changed in the backend. - your_name_here
Extra info is not filled out in text: * Extra info.
Author is not set in text: + Removed cool feature. - your_name_here
Extra info is not filled out in text: * Extra info.

Title issues:
PR title does not match the expected format of 'Category: Title'

Please fix these issues. For the correct format, refer to the pull request template.

github-actions · 2025-01-09T19:23:25Z

edited, so that i dont need to scroll so much anymore ~hannibal

One or more Detekt Failures were detected:

ToolTooltipTweaksMining.kt#L6: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L8: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L9: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L18: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L23: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L65: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L67: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L68: Expected space after opening comment.
MiningStatsDisplay.kt#L75: Expected space after opening comment.
MiningStatsDisplay.kt#L139: Expected space after opening comment.
MiningStatsDisplay.kt#L140: Expected space after opening comment.
MiningStatsDisplay.kt#L148: Expected space after opening comment.
MiningStatsDisplay.kt#L149: Expected space after opening comment.
MiningStatsDisplay.kt#L150: Expected space after opening comment.
MiningStatsDisplay.kt#L166: Expected space after opening comment.
MiningStatsDisplay.kt#L167: Expected space after opening comment.
MiningStatsDisplay.kt#L189: Expected space after opening comment.
MiningStatsDisplay.kt#L191: Expected space after opening comment.
MiningStatsDisplay.kt#L197: Expected space after opening comment.
MiningStatsDisplay.kt#L199: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L2: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
MiningStatsDisplay.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
MiningStatsDisplay.kt#L54: Repo pattern universalTabFortunePattern must have a regex test.
ToolTooltipTweaks.kt#L77: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L78: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L80: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L82: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L83: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L84: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L85: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L86: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L87: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L88: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L89: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L90: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L91: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L93: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L94: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L95: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L97: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L98: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L100: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L101: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L102: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L103: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L105: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L106: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L107: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L108: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L109: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L110: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L111: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L112: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L113: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L114: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L115: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L116: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L117: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L118: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L119: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L120: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L121: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L122: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L123: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L124: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L125: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L126: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L127: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L128: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L129: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L130: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L131: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L132: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L133: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L134: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L135: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L136: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L137: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L138: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L139: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L140: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L141: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L142: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L143: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L144: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L145: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L146: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L147: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L148: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L149: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L150: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L151: Unexpected indentation (32) (should be 28)
ToolTooltipTweaks.kt#L152: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L153: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L154: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L155: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L156: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L157: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L158: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L159: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L160: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L161: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L162: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L163: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L164: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L165: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L166: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L167: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L168: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L169: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L170: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L171: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L172: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L173: Unexpected indentation (4) (should be 0)
ToolTooltipTweaksMining.kt#L63: Unexpected spacing before ")"
MiningStatsDisplay.kt#L5: Unused import
MiningStatsDisplay.kt#L6: Unused import
MiningStatsDisplay.kt#L7: Unused import
MiningStatsDisplay.kt#L8: Unused import
MiningStatsDisplay.kt#L9: Unused import
MiningStatsDisplay.kt#L10: Unused import
MiningStatsDisplay.kt#L11: Unused import
MiningStatsDisplay.kt#L12: Unused import
MiningStatsDisplay.kt#L13: Unused import
MiningStatsDisplay.kt#L14: Unused import
MiningStatsDisplay.kt#L15: Unused import
MiningStatsDisplay.kt#L17: Unused import
MiningStatsDisplay.kt#L19: Unused import
MiningStatsDisplay.kt#L20: Unused import
MiningStatsDisplay.kt#L21: Unused import
MiningStatsDisplay.kt#L22: Unused import
MiningStatsDisplay.kt#L23: Unused import
MiningStatsDisplay.kt#L27: Unused import
MiningStatsDisplay.kt#L28: Unused import
MiningStatsDisplay.kt#L29: Unused import
MiningStatsDisplay.kt#L32: Unused import
MiningStatsDisplay.kt#L33: Unused import
MiningStatsDisplay.kt#L37: Unused import
MiningStatsDisplay.kt#L38: Unused import
MiningStatsDisplay.kt#L40: Unused import
MiningStatsDisplay.kt#L41: Unused import
MiningStatsDisplay.kt#L44: Unused import
MiningStatsDisplay.kt#L45: Unused import
MiningStatsDisplay.kt#L46: Unused import
MiningStatsDisplay.kt#L47: Unused import
MiningStatsDisplay.kt#L108: Unexpected whitespace
MiningStatsDisplay.kt#L120: Unexpected whitespace
MiningStatsDisplay.kt#L193: Unexpected indentation (12) (should be 8)
MiningStatsDisplay.kt#L194: Unexpected indentation (8) (should be 4)
MiningStatsDisplay.kt#L195: Unexpected indentation (4) (should be 0)
MiningStatsDisplay.kt#L197: Unexpected indentation (4) (should be 0)
MiningStatsDisplay.kt#L199: Unexpected indentation (4) (should be 0)
MiningStatsDisplay.kt#L201: Unexpected indentation (4) (should be 0)
MiningStatsDisplay.kt#L202: Unexpected indentation (4) (should be 0)
MiningStatsDisplay.kt#L203: Unexpected indentation (8) (should be 4)
MiningStatsDisplay.kt#L204: Unexpected indentation (8) (should be 4)
MiningStatsDisplay.kt#L205: Unexpected indentation (8) (should be 4)
MiningStatsDisplay.kt#L206: Unexpected indentation (4) (should be 0)
MiningStatsDisplay.kt#L119: Unexpected spacing before ")"
MiningStatsDisplay.kt#L108: Unexpected spacing before ":"
MiningStatsDisplay.kt#L120: Unexpected spacing before ":"
ToolTooltipTweaksMining.kt#L86: Name shadowed: baseFortune
ToolTooltipTweaksMining.kt#L87: Name shadowed: fortuneFortune
ToolTooltipTweaksMining.kt#L88: Name shadowed: omeletteFortune
ToolTooltipTweaksMining.kt#L89: Name shadowed: engineFortune
ToolTooltipTweaks.kt#L39: Private property tooltipFortunePattern is unused.
MiningStatsDisplay.kt#L120: Function getEngineFortune has 6 return statements which exceeds the limit of 5.
MiningStatsDisplay.kt#L54: Private property universalTabFortunePattern is unused.

github-actions · 2025-01-09T19:23:30Z

I have detected some issues with your pull request:

Body issues:
No changes detected in this pull request

Please fix these issues. For the correct format, refer to the pull request template.

CalMWolfs · 2025-01-09T19:53:49Z

hey if you want to discuss any of this or need some help on anything feel free to ask in the #coding channel in the skyhanni discord

Co-authored-by: hannibal2 <[email protected]>

…002#3186)

github-actions · 2025-01-10T16:59:48Z

Again, i dont want to scroll so much ~hannibal2

One or more Detekt Failures were detected:

ToolTooltipTweaksMining.kt#L7: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L9: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L10: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L19: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L24: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L71: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L73: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L74: Expected space after opening comment.
MiningStatsDisplay.kt#L95: Expected space after opening comment.
MiningStatsDisplay.kt#L96: Expected space after opening comment.
MiningStatsDisplay.kt#L104: Expected space after opening comment.
MiningStatsDisplay.kt#L105: Expected space after opening comment.
MiningStatsDisplay.kt#L106: Expected space after opening comment.
MiningStatsDisplay.kt#L122: Expected space after opening comment.
MiningStatsDisplay.kt#L123: Expected space after opening comment.
MiningStatsDisplay.kt#L157: Expected space after opening comment.
MiningStatsDisplay.kt#L159: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L2: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
MiningStatsDisplay.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
MiningStatsDisplay.kt#L24: Repo pattern universalTabFortunePattern must have a regex test.
ToolTooltipTweaks.kt#L77: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L78: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L80: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L82: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L83: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L84: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L85: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L86: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L87: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L88: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L89: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L90: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L91: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L93: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L94: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L95: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L97: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L98: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L100: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L101: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L102: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L103: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L105: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L106: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L107: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L108: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L109: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L110: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L111: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L112: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L113: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L114: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L115: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L116: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L117: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L118: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L119: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L120: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L121: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L122: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L123: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L124: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L125: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L126: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L127: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L128: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L129: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L130: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L131: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L132: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L133: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L134: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L135: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L136: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L137: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L138: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L139: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L140: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L141: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L142: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L143: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L144: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L145: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L146: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L147: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L148: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L149: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L150: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L151: Unexpected indentation (32) (should be 28)
ToolTooltipTweaks.kt#L152: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L153: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L154: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L155: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L156: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L157: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L158: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L159: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L160: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L161: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L162: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L163: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L164: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L165: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L166: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L167: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L168: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L169: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L170: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L171: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L172: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L173: Unexpected indentation (4) (should be 0)
ToolTooltipTweaksMining.kt#L3: Unused import
ToolTooltipTweaksMining.kt#L4: Unused import
ToolTooltipTweaksMining.kt#L5: Unused import
ToolTooltipTweaksMining.kt#L8: Unused import
ToolTooltipTweaksMining.kt#L11: Unused import
ToolTooltipTweaksMining.kt#L13: Unused import
ToolTooltipTweaksMining.kt#L22: Unused import
ToolTooltipTweaksMining.kt#L27: Unused import
ToolTooltipTweaksMining.kt#L96: Initial star should align with start of block comment
ToolTooltipTweaksMining.kt#L158: Initial star should align with start of block comment
ToolTooltipTweaksMining.kt#L183: Initial star should align with start of block comment
MiningStatsDisplay.kt#L3: Unused import
MiningStatsDisplay.kt#L4: Unused import
MiningStatsDisplay.kt#L7: Unused import
MiningStatsDisplay.kt#L10: Unused import
MiningStatsDisplay.kt#L11: Unused import
MiningStatsDisplay.kt#L78: Missing spacing after "if"
MiningStatsDisplay.kt#L52: Unexpected spacing before ")"
MiningStatsDisplay.kt#L67: Unnecessary long whitespace
MiningStatsDisplay.kt#L80: Unnecessary long whitespace
MiningStatsDisplay.kt#L82: Unnecessary long whitespace
MiningStatsDisplay.kt#L84: Unnecessary long whitespace
MiningStatsDisplay.kt#L86: Unnecessary long whitespace
MiningStatsDisplay.kt#L52: Missing spacing after ","
MiningStatsDisplay.kt#L81: Unexpected indentation (17) (should be 16)
MiningStatsDisplay.kt#L83: Unexpected indentation (17) (should be 16)
MiningStatsDisplay.kt#L85: Unexpected indentation (17) (should be 16)
MiningStatsDisplay.kt#L87: Unexpected indentation (17) (should be 16)
ToolTooltipTweaks.kt#L39: Private property tooltipFortunePattern is unused.
ToolTooltipTweaksMining.kt#L40: Private property counterStartLine is unused.
ToolTooltipTweaksMining.kt#L41: Private property reforgeEndLine is unused.
ToolTooltipTweaksMining.kt#L42: Private property ABILITY_DESCRIPTION_START is unused.
ToolTooltipTweaksMining.kt#L43: Private property ABILITY_DESCRIPTION_END is unused.
ToolTooltipTweaksMining.kt#L59: Private property reforgeName is unused.
ToolTooltipTweaksMining.kt#L79: Private property removingFarmhandDescription is unused.
ToolTooltipTweaksMining.kt#L80: Private property removingCounterDescription is unused.
ToolTooltipTweaksMining.kt#L81: Private property removingReforgeDescription is unused.
ToolTooltipTweaksMining.kt#L82: Private property removingAbilityDescription is unused.
ToolTooltipTweaksMining.kt#L79: Variable 'removingFarmhandDescription' could be val.
ToolTooltipTweaksMining.kt#L80: Variable 'removingCounterDescription' could be val.
ToolTooltipTweaksMining.kt#L81: Variable 'removingReforgeDescription' could be val.
ToolTooltipTweaksMining.kt#L82: Variable 'removingAbilityDescription' could be val.
MiningStatsDisplay.kt#L24: Private property universalTabFortunePattern is unused.
MiningStatsDisplay.kt#L30: Private property miningFortunePattern is unused.

github-actions · 2025-01-10T23:07:12Z

I have detected some issues with your pull request:

Body issues:
No changes detected in this pull request

Please fix these issues. For the correct format, refer to the pull request template.

hannibal002

Given the amount of still commented out code i make this a draft pr.
Also please add the changelog in the pr description - see the template

hannibal002 · 2025-01-10T23:06:10Z

src/main/java/at/hannibal2/skyhanni/config/features/garden/TooltipTweaksConfig.java

@@ -17,7 +17,7 @@ public class TooltipTweaksConfig {
    )
    @ConfigEditorBoolean
    @FeatureToggle
-    public boolean compactToolTooltips = false;


unrelated change, please revert

hannibal002 · 2025-01-10T23:06:42Z

src/main/java/at/hannibal2/skyhanni/config/features/mining/BreakDownConfig.java

+import io.github.notenoughupdates.moulconfig.annotations.ConfigOption;
+import org.lwjgl.input.Keyboard;
+
+public class BreakDownConfig {


please add the prefix mining to the class name, and lowercase the D in breakdown

github-actions · 2025-01-10T23:10:02Z

One or more Detekt Failures were detected:

ToolTooltipTweaksMining.kt#L7: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L9: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L10: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L19: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L24: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L71: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L73: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L74: Expected space after opening comment.
MiningStatsDisplay.kt#L95: Expected space after opening comment.
MiningStatsDisplay.kt#L96: Expected space after opening comment.
MiningStatsDisplay.kt#L104: Expected space after opening comment.
MiningStatsDisplay.kt#L105: Expected space after opening comment.
MiningStatsDisplay.kt#L106: Expected space after opening comment.
MiningStatsDisplay.kt#L122: Expected space after opening comment.
MiningStatsDisplay.kt#L123: Expected space after opening comment.
MiningStatsDisplay.kt#L157: Expected space after opening comment.
MiningStatsDisplay.kt#L159: Expected space after opening comment.
ToolTooltipTweaksMining.kt#L2: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
MiningStatsDisplay.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
MiningStatsDisplay.kt#L24: Repo pattern universalTabFortunePattern must have a regex test.
ToolTooltipTweaks.kt#L77: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L78: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L80: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L82: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L83: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L84: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L85: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L86: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L87: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L88: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L89: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L90: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L91: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L93: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L94: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L95: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L97: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L98: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L100: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L101: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L102: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L103: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L105: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L106: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L107: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L108: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L109: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L110: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L111: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L112: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L113: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L114: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L115: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L116: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L117: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L118: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L119: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L120: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L121: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L122: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L123: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L124: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L125: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L126: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L127: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L128: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L129: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L130: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L131: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L132: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L133: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L134: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L135: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L136: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L137: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L138: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L139: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L140: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L141: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L142: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L143: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L144: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L145: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L146: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L147: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L148: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L149: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L150: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L151: Unexpected indentation (32) (should be 28)
ToolTooltipTweaks.kt#L152: Unexpected indentation (28) (should be 24)
ToolTooltipTweaks.kt#L153: Unexpected indentation (24) (should be 20)
ToolTooltipTweaks.kt#L154: Unexpected indentation (20) (should be 16)
ToolTooltipTweaks.kt#L155: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L156: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L157: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L158: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L159: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L160: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L161: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L162: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L163: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L164: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L165: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L166: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L167: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L168: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L169: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L170: Unexpected indentation (16) (should be 12)
ToolTooltipTweaks.kt#L171: Unexpected indentation (12) (should be 8)
ToolTooltipTweaks.kt#L172: Unexpected indentation (8) (should be 4)
ToolTooltipTweaks.kt#L173: Unexpected indentation (4) (should be 0)
ToolTooltipTweaksMining.kt#L3: Unused import
ToolTooltipTweaksMining.kt#L4: Unused import
ToolTooltipTweaksMining.kt#L5: Unused import
ToolTooltipTweaksMining.kt#L8: Unused import
ToolTooltipTweaksMining.kt#L11: Unused import
ToolTooltipTweaksMining.kt#L13: Unused import
ToolTooltipTweaksMining.kt#L22: Unused import
ToolTooltipTweaksMining.kt#L27: Unused import
ToolTooltipTweaksMining.kt#L96: Initial star should align with start of block comment
ToolTooltipTweaksMining.kt#L158: Initial star should align with start of block comment
ToolTooltipTweaksMining.kt#L183: Initial star should align with start of block comment
MiningStatsDisplay.kt#L78: Missing spacing after "if"
MiningStatsDisplay.kt#L3: Unused import
MiningStatsDisplay.kt#L4: Unused import
MiningStatsDisplay.kt#L7: Unused import
MiningStatsDisplay.kt#L10: Unused import
MiningStatsDisplay.kt#L11: Unused import
MiningStatsDisplay.kt#L52: Missing spacing after ","
MiningStatsDisplay.kt#L81: Unexpected indentation (17) (should be 16)
MiningStatsDisplay.kt#L83: Unexpected indentation (17) (should be 16)
MiningStatsDisplay.kt#L85: Unexpected indentation (17) (should be 16)
MiningStatsDisplay.kt#L87: Unexpected indentation (17) (should be 16)
MiningStatsDisplay.kt#L52: Unexpected spacing before ")"
MiningStatsDisplay.kt#L67: Unnecessary long whitespace
MiningStatsDisplay.kt#L80: Unnecessary long whitespace
MiningStatsDisplay.kt#L82: Unnecessary long whitespace
MiningStatsDisplay.kt#L84: Unnecessary long whitespace
MiningStatsDisplay.kt#L86: Unnecessary long whitespace
ToolTooltipTweaks.kt#L39: Private property tooltipFortunePattern is unused.
ToolTooltipTweaksMining.kt#L40: Private property counterStartLine is unused.
ToolTooltipTweaksMining.kt#L41: Private property reforgeEndLine is unused.
ToolTooltipTweaksMining.kt#L42: Private property ABILITY_DESCRIPTION_START is unused.
ToolTooltipTweaksMining.kt#L43: Private property ABILITY_DESCRIPTION_END is unused.
ToolTooltipTweaksMining.kt#L59: Private property reforgeName is unused.
ToolTooltipTweaksMining.kt#L79: Private property removingFarmhandDescription is unused.
ToolTooltipTweaksMining.kt#L80: Private property removingCounterDescription is unused.
ToolTooltipTweaksMining.kt#L81: Private property removingReforgeDescription is unused.
ToolTooltipTweaksMining.kt#L82: Private property removingAbilityDescription is unused.
ToolTooltipTweaksMining.kt#L79: Variable 'removingFarmhandDescription' could be val.
ToolTooltipTweaksMining.kt#L80: Variable 'removingCounterDescription' could be val.
ToolTooltipTweaksMining.kt#L81: Variable 'removingReforgeDescription' could be val.
ToolTooltipTweaksMining.kt#L82: Variable 'removingAbilityDescription' could be val.
MiningStatsDisplay.kt#L24: Private property universalTabFortunePattern is unused.
MiningStatsDisplay.kt#L30: Private property miningFortunePattern is unused.

github-actions · 2025-01-10T23:10:05Z

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

AuroZed added 3 commits January 9, 2025 11:08

idk changes ?

b13327d

changes

54854fd

changes

8036d1d

github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Jan 9, 2025

github-actions bot added the Detekt Has detekt problem label Jan 9, 2025

hannibal002 and others added 8 commits January 10, 2025 17:53

Backend: Repo pattern dashes and fixes (hannibal002#3115)

4c5bdca

Co-authored-by: hannibal2 <[email protected]>

Fix: GardenKeybinds not working with Inventory/Chat Keybind (hannibal…

24095fb

…002#3186)

version bump 1.3.0

680d245

added base stats from hypixel item api

6ca354f

made keys lower case

afb028c

orEmpty

7313a7d

Almost done, just need the gemstone fortune and reforge

5a0c1d8

Almost done, just need the gemstone fortune and reforge

a61366f

Merge branch 'refs/heads/beta' into fork/AuroZed/beta

e99dc6c

hannibal002 added the Waiting on Dependency PR waiting for a dependency pr to be merged label Jan 10, 2025

hannibal002 requested changes Jan 10, 2025

View reviewed changes

hannibal002 marked this pull request as draft January 10, 2025 23:09

github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change for with no lead #3190

Change for with no lead #3190

AuroZed commented Jan 9, 2025 •

edited by hannibal002

Loading

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025 •

edited by hannibal002

Loading

One or more Detekt Failures were detected:

github-actions bot commented Jan 9, 2025

CalMWolfs commented Jan 9, 2025

github-actions bot commented Jan 10, 2025 •

edited by hannibal002

Loading

One or more Detekt Failures were detected:

github-actions bot commented Jan 10, 2025

hannibal002 left a comment

hannibal002 Jan 10, 2025

hannibal002 Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

Change for with no lead #3190

Are you sure you want to change the base?

Change for with no lead #3190

Conversation

AuroZed commented Jan 9, 2025 • edited by hannibal002 Loading

Dependencies

What

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025 • edited by hannibal002 Loading

One or more Detekt Failures were detected:

github-actions bot commented Jan 9, 2025

CalMWolfs commented Jan 9, 2025

github-actions bot commented Jan 10, 2025 • edited by hannibal002 Loading

One or more Detekt Failures were detected:

github-actions bot commented Jan 10, 2025

hannibal002 left a comment

Choose a reason for hiding this comment

hannibal002 Jan 10, 2025

Choose a reason for hiding this comment

hannibal002 Jan 10, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 10, 2025

One or more Detekt Failures were detected:

github-actions bot commented Jan 10, 2025

AuroZed commented Jan 9, 2025 •

edited by hannibal002

Loading

github-actions bot commented Jan 9, 2025 •

edited by hannibal002

Loading

github-actions bot commented Jan 10, 2025 •

edited by hannibal002

Loading