Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adds a reminder to select the Rabbit pet #3195

Open
wants to merge 9 commits into
base: beta
Choose a base branch
from

Conversation

BearySuperior
Copy link
Contributor

@BearySuperior BearySuperior commented Jan 10, 2025

What

Adds a reminder to select the Rabbit pet while doing visitors to maximize XP gain.
https://discord.com/channels/997079228510117908/1266608229396250624

Changelog New Features

  • Added an option to block accepting visitors without a rabbit pet equipped. - BearySuperior

Adds the option to block accepting visitors without a Rabbit pet enabled
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Jan 10, 2025
Copy link

I have detected some issues with your pull request:

Body issues:
Change should start with 'Added' instead of 'Add' in text: Adds an option to block accepting visitors without a rabbit pet equipped.

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added Detekt Has detekt problem and removed Wrong Title/Changelog There is an error in the title or changelog labels Jan 10, 2025
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Jan 10, 2025
@hannibal002 hannibal002 added this to the Version 2.0.0 milestone Jan 10, 2025
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jan 10, 2025
@hannibal002
Copy link
Owner

This does not work if "cheap copper" is enabled and would allow you to accept the visitor.
We need a different approach to implementing this, im afraid. with separate blocks of accept and refuse, and that allows blocking both (since currently a valid visitor would onyl get blocked for accepting, but the refuse button would be highlighted and we dont want this without rabbit.

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Soon This Pull Request will be merged within the next couple of betas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants