Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Change: Cleanup CaptureFarmingGear #739

Closed

Conversation

walkerselby
Copy link
Contributor

No description provided.

…ked again if they already matched

Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Refactor duplicated code to function, and prevent unneeded checking by returning once a match is found.

Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
@hannibal002 hannibal002 added this to the Version 0.22 milestone Nov 30, 2023
@hannibal002 hannibal002 added Soon This Pull Request will be merged within the next couple of betas and removed Soon This Pull Request will be merged within the next couple of betas labels Nov 30, 2023
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 30, 2023
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/garden/fortuneguide/CaptureFarmingGear.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 30, 2023
Copy link

Conflicts have been resolved! 🎉

@jani270 jani270 modified the milestones: Version 0.22, Version 0.23 Dec 14, 2023
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 16, 2023
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/garden/fortuneguide/CaptureFarmingGear.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 17, 2023
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 11, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@walkerselby
Copy link
Contributor Author

This PR is now stale, being 4 months old. Will revisit and re-implement when I have time.

@walkerselby walkerselby closed this Feb 5, 2024
@walkerselby walkerselby deleted the cleanup-capturefarminggear branch February 5, 2024 15:55
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants