-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Extra Harp Features #741
Feature: Extra Harp Features #741
Conversation
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/utils/LorenzUtils.kt
041b5ce
to
3f670c1
Compare
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/inventory/HarpFeatures.kt
Conflicts have been resolved! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not get a chance to test the code but the rest of it looks good apart from these small changes needed for the config file
src/main/java/at/hannibal2/skyhanni/config/features/inventory/helper/HelperConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/main/java/at/hannibal2/skyhanni/config/features/inventory/helper/HelperConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/inventory/helper/HelperConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/HarpFeatures.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/HarpFeatures.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/HarpFeatures.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/HarpFeatures.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/HarpFeatures.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/HarpFeatures.kt
Outdated
Show resolved
Hide resolved
Fixed. |
Dependencies
What
Addes 2 small features and a small Fix (maybe should have split it but is only small things)
Addes an auto Scale feature which sets the GUI size to "AUTO".
Addes a quick Restart feature which lets you start the last played Song by pressing the close button shortly after opening the Harp.
Also limits the stacksize tooltip to 3 characters because keys like "Space" are to long