Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Extra Harp Features #741

Merged
merged 14 commits into from
Jan 21, 2024

Conversation

Thunderblade73
Copy link
Contributor

@Thunderblade73 Thunderblade73 commented Nov 29, 2023

Dependencies

What

Addes 2 small features and a small Fix (maybe should have split it but is only small things)
Addes an auto Scale feature which sets the GUI size to "AUTO".
Addes a quick Restart feature which lets you start the last played Song by pressing the close button shortly after opening the Harp.
Also limits the stacksize tooltip to 3 characters because keys like "Space" are to long

@hannibal002 hannibal002 added this to the Version 0.22 milestone Nov 30, 2023
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 30, 2023
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@Thunderblade73 Thunderblade73 marked this pull request as draft December 7, 2023 21:40
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

Conflicts have been resolved! 🎉

@Thunderblade73 Thunderblade73 marked this pull request as ready for review December 8, 2023 16:12
@jani270 jani270 modified the milestones: Version 0.22, Version 0.23 Dec 14, 2023
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 11, 2024
Thunderblade73 and others added 2 commits January 13, 2024 14:57
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/inventory/HarpFeatures.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 13, 2024
Copy link

Conflicts have been resolved! 🎉

Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not get a chance to test the code but the rest of it looks good apart from these small changes needed for the config file

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jan 20, 2024
@hannibal002 hannibal002 self-requested a review January 20, 2024 12:14
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Melody inventory is sometimes small, sometimes big when I click and open and close the inventory in rapid succession.
image
image

@Thunderblade73
Copy link
Contributor Author

Fixed.

@hannibal002 hannibal002 merged commit 6379632 into hannibal002:beta Jan 21, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jan 21, 2024
@Thunderblade73 Thunderblade73 deleted the harp-Helper-better branch February 9, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants