Add Waypoints for 2023 Lobby Presents #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
Signed-off-by: Walker Selby <[email protected]>
hannibal002
added
the
Soon
hannibal002
requested changes
Dec 8, 2023
There was a problem hiding this comment.
Please change the name of the settings/feature/classes JSON objects/repo file keys to reflect this is 2023 winter lobby presents.
I don't know if the location is the same each year, but at least the event name winter lobby presents should be included everywhere, right? Or is this intended to be abstract? I'm not sure for each class.
Resolved in conversation in Discord |
hannibal002
approved these changes
Dec 9, 2023
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move packages
Add locraw support for HypixelData
Add todos
This needs repo pr 67