Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix: modify instead of block trophy fishing and sea creature messages #827

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Minor fix: modify instead of block trophy fishing and sea creature messages #827

merged 3 commits into from
Jan 6, 2024

Conversation

appable0
Copy link
Contributor

Fixes https://discord.com/channels/997079228510117908/1187222863141408909

  • Modify messages in SeaCreatureMessageShortener instead of blocking and resending
  • Modify messages in TrophyFishMessages instead of blocking and resending
  • Minor cleanup of some confusing logic in above classes
  • Added chatLineId (default 0) to LorenzChatEvent, which uses printChatMessageWithOptionalDeletion to allow retracting a family of previous messages

@hannibal002 hannibal002 added this to the Version 0.23 milestone Dec 23, 2023
@hannibal002 hannibal002 modified the milestones: Version 0.23, Version 0.24 Jan 1, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jan 2, 2024
@hannibal002 hannibal002 modified the milestones: Version 0.24, Version 0.23 Jan 2, 2024
@hannibal002 hannibal002 added Bug Fix Bug fixes and removed Soon This Pull Request will be merged within the next couple of betas labels Jan 2, 2024
@hannibal002 hannibal002 self-requested a review January 2, 2024 21:43
@hannibal002 hannibal002 merged commit 4a5ece2 into hannibal002:beta Jan 6, 2024
2 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Jan 6, 2024
Thunderblade73 pushed a commit to Thunderblade73/SkyHanni that referenced this pull request Jan 7, 2024
@Thunderblade73
Minor fix: modify instead of block trophy fishing and sea creature me…
43c28ef 
…ssages (hannibal002#827)

Modify instead of block trophy fishing and sea creature chat messages. hannibal002#827
@appable0 appable0 deleted the fix-blocked-sea-creature-messages branch May 17, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 hannibal002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.23
Development

Successfully merging this pull request may close these issues.
2 participants
@appable0 @hannibal002