Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix IslandType detection for The Rift #877

Merged
merged 3 commits into from
Jan 6, 2024

Conversation

ItsEmpa
Copy link
Contributor

@ItsEmpa ItsEmpa commented Jan 4, 2024

Broke in #823

@j10a1n15
Copy link
Contributor

j10a1n15 commented Jan 4, 2024

Actually while youre at it, knowing Hyixel, can you change the pattern to (§.)*(Area|Dungeon): (§.)*(?<island>.*)

@hannibal002 hannibal002 added the Bug Fix Bug fixes label Jan 4, 2024
@hannibal002 hannibal002 added this to the Version 0.23 milestone Jan 4, 2024
@hannibal002 hannibal002 self-requested a review January 6, 2024 11:05
@hannibal002 hannibal002 merged commit f4c86a2 into hannibal002:beta Jan 6, 2024
2 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Jan 6, 2024
Thunderblade73 pushed a commit to Thunderblade73/SkyHanni that referenced this pull request Jan 7, 2024
Changed regex in case hypixel changes color codes for island name in tab list. hannibal002#877
@ItsEmpa ItsEmpa deleted the fix-rift-detection branch March 28, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants