Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: ShiftClickNPCSell #907

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Feature: ShiftClickNPCSell #907

merged 6 commits into from
Jan 11, 2024

Conversation

Thunderblade73
Copy link
Contributor

CalMWolfs
CalMWolfs approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hannibal002 hannibal002 self-requested a review January 11, 2024 16:56
hannibal002
hannibal002 requested changes Jan 11, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks clean and works for me, i just added couple small nitpick stuff to change please

src/main/java/at/hannibal2/skyhanni/config/features/inventory/InventoryConfig.java Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/ShiftClickNPCSell.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/ShiftClickNPCSell.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/ShiftClickNPCSell.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/ShiftClickNPCSell.kt Outdated Show resolved Hide resolved
@hannibal002 hannibal002 added this to the Version 0.23 milestone Jan 11, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jan 11, 2024
@hannibal002 hannibal002 self-requested a review January 11, 2024 17:35
hannibal002
hannibal002 requested changes Jan 11, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I promise this is the last review

src/main/java/at/hannibal2/skyhanni/features/inventory/HideNotClickableItems.kt Outdated Show resolved Hide resolved
@hannibal002 hannibal002 merged commit 844e627 into hannibal002:beta Jan 11, 2024
2 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jan 11, 2024
@Thunderblade73 Thunderblade73 deleted the shift-click-sell branch January 21, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 hannibal002 approved these changes

@CalMWolfs CalMWolfs CalMWolfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.23
Development

Successfully merging this pull request may close these issues.
3 participants
@Thunderblade73 @hannibal002 @CalMWolfs