Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request elections api less frequently #966

Merged
merged 1 commit into from
Jan 30, 2024
Merged

request elections api less frequently #966

merged 1 commit into from
Jan 30, 2024

Conversation

CalMWolfs
Copy link
Collaborator

  • request elections api a little less
  • use simple time mark
  • remove nested if
  • convert two logError() to logErrorWithData()

@Thunderblade73
Copy link
Contributor

This looks like the changes done in #925. Except the less frequent thingy.

@CalMWolfs
Copy link
Collaborator Author

This looks like the changes done in #925. Except the less frequent thingy.

Damn didnt even see that, well this would probably be a more temporary fix as that pr looks like it does much more but ill leave this open as it does remove two depreciated things and improves the api being requested too frequently for now

j10a1n15 added a commit to j10a1n15/SkyHanni that referenced this pull request Jan 30, 2024
@j10a1n15
Upped the check api time like in hannibal002#966 and stole the check …
3938a4c 
…code :)
@hannibal002 hannibal002 added this to the Version 0.23 milestone Jan 30, 2024
@hannibal002 hannibal002 self-requested a review January 30, 2024 21:17
@hannibal002 hannibal002 merged commit b3876ec into hannibal002:beta Jan 30, 2024
3 checks passed
@CalMWolfs CalMWolfs deleted the api-changes branch January 30, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 hannibal002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.23
Development

Successfully merging this pull request may close these issues.
3 participants
@CalMWolfs @Thunderblade73 @hannibal002