Implementation of Barycentric Coordinates #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-wriglesworth
force-pushed
the
main
branch
from
2ae807a to
aeea23a
Compare
luke-wriglesworth
force-pushed
the
main
branch
from
aeea23a to
3a2e3df
Compare
…rything at the end. Transformation error looks similar to other coordinate systems now.
… perfectly, but for differing masses it will need to be changed to something more general. For systems with more than two bodies I set it to use the first mass as eta. This works much better than using the total system mass in all scenarios I tested it with.
|
Hi Hanno, I think it is ready to be merged now. There is a test failing because of the codecov token, I'm not sure why. |
|
Thanks Nick. This looks great. Give me a couple of days to test various edge cases. In the meantime, maybe you can think about examples where we can get good performance using these coordinates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the transformations I used something similar to Jacobi coordinates, where the first coordinate points to the center of mass and the other coordinates are calculated relative to it.