fix: add quotes to href attribute

haocheng6 · Dec 26, 2023 · f797375 · f797375
1 parent 754683a
commit f797375
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -55,7 +55,7 @@ const remarkGithubCodeImport: Plugin<[options: Options] | void[], Root> = (
         node,
         {
           type: 'html',
-          value: `<div class="github-code-link"><a href=${url} target="_blank">See full example on GitHub</a></div>`,
+          value: `<div class="github-code-link"><a href="${url}" target="_blank">See full example on GitHub</a></div>`,
         } satisfies Html,
         {
           type: 'html',

diff --git a/test/fixtures/output/entire_file.md b/test/fixtures/output/entire_file.md
@@ -18,6 +18,6 @@ export function once(fn) {
 }
 ```
 
-<div class="github-code-link"><a href=https://github.com/user/repo/blob/branch/folder/example.js target="_blank">See full example on GitHub</a></div>
+<div class="github-code-link"><a href="https://github.com/user/repo/blob/branch/folder/example.js" target="_blank">See full example on GitHub</a></div>
 
 </div>
diff --git a/test/fixtures/output/line_range.md b/test/fixtures/output/line_range.md
@@ -12,6 +12,6 @@
   };
 ```
 
-<div class="github-code-link"><a href=https://github.com/user/repo/blob/branch/folder/example.js#L6-L12 target="_blank">See full example on GitHub</a></div>
+<div class="github-code-link"><a href="https://github.com/user/repo/blob/branch/folder/example.js#L6-L12" target="_blank">See full example on GitHub</a></div>
 
 </div>
diff --git a/test/fixtures/output/line_range_dedented.md b/test/fixtures/output/line_range_dedented.md
@@ -12,6 +12,6 @@ return function (...args) {
 };
 ```
 
-<div class="github-code-link"><a href=https://github.com/user/repo/blob/branch/folder/example.js#L6-L12 target="_blank">See full example on GitHub</a></div>
+<div class="github-code-link"><a href="https://github.com/user/repo/blob/branch/folder/example.js#L6-L12" target="_blank">See full example on GitHub</a></div>
 
 </div>