Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eval_science_qa.py #1530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update eval_science_qa.py #1530

wants to merge 1 commit into from

Conversation

jubinchheda
Copy link

  • Use a set for split_indices and predictions to speed up lookup times.
  • Read files in a more efficient manner using with statements to ensure proper file handling.
  • Simplify the loop by combining conditions and removing redundant checks.
  • Use list comprehensions for filtering and counting.

@jubinchheda
Update eval_science_qa.py
1843325 
* Use a set for split_indices and predictions to speed up lookup times.
* Read files in a more efficient manner using with statements to ensure proper file handling.
* Simplify the loop by combining conditions and removing redundant checks.
* Use list comprehensions for filtering and counting.
@jubinchheda
Copy link
Author

Can we merge this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xufengduan xufengduan xufengduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jubinchheda @xufengduan