-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump org.hl7.fhir.core to 6.4.4 #6620
base: master
Are you sure you want to change the base?
Conversation
…rser-contained-ids
Formatting check succeeded! |
Hi and thanks for your effort. Wouldn't be better to target directly the 6.5.x Version of Core Libraries (currently at 6.5.11)? It seems that there are some breaking changes and the Validator isn't working anymore:
|
@madduci Ideally, yes, we should be targeting 6.5.11, and that is the eventual goal. When doing bumps of this library in the past, I have encountered cases where there are many breaking changes in the underlying logic. These can cause many test failures. In the worst cases, the breaking changes may even interact. Incrementing in smaller jumps is an attempt to manage a minimal amount of changes in one PR. I have found this safer and easier to review. @tadgh, I've been using this approach for some time now, and you've reviewed a few of these. Do smaller increments still seem reasonable? |
@madduci I'm happy that you are maintaining your own PR, and will be happy to review it once it passes tests. Please be aware that this PR is not complete. It still fails many tests, and I am still trying to fix them. Keep this in mind when you develop your own. |
No description provided.