Throw DataFormatException with polymorphic item without .ofType() function #6721
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m (expected .ofType() function after polymorphic item <item_name>)" in case of polymorphic fields without specifying the wanted type
|
Hi @bratwurzt , thanks for the contribution! Would you be able to add a test which exercises the new behaviour? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6721 +/- ##
============================================
- Coverage 83.58% 83.58% -0.01%
- Complexity 28650 28656 +6
============================================
Files 1798 1798
Lines 111363 111378 +15
Branches 13982 13984 +2
============================================
+ Hits 93080 93092 +12
- Misses 12280 12284 +4
+ Partials 6003 6002 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error message: "Unexpected end of stream (expected .ofType() function after polymorphic item <item_name>)" in case of polymorphic fields without specifying the wanted type.
Closes #6720