Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JpaPackageCache.java #6762

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update JpaPackageCache.java #6762

wants to merge 5 commits into from

Conversation

jkiddo
Copy link
Contributor

@jkiddo jkiddo commented Feb 27, 2025

Fix for #5834

Copy link
Contributor

@dotasek dotasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks correct, but there are a few things needed.

  1. This wouldn't initially compile for me. I needed to add the following imports:
import org.hl7.fhir.instance.model.api.IBase;
import org.hl7.fhir.instance.model.api.IBaseBackboneElement;
  1. If I understand the issue correctly, I think it would be possible to replicate the original failure in JpaPackageCacheTest with something similar to this:
try (InputStream stream = ClasspathUtil.loadResourceAsStream("/packages/hl7.fhir.uv.shorthand-0.12.0.tgz")) {				
  myPackageCacheManager.addPackageToCache("hl7.fhir.uv.shorthand", "0.12.0", stream, "hl7.fhir.uv.shorthand"); 
}

I was about to do so myself, but the IG in the original issue is not available: https://build.fhir.org/ig/WorldHealthOrganization/smart-anc/package.tgz

  1. This needs a changelog entry before anyone authorizes the merge.

@jkiddo
Copy link
Contributor Author

jkiddo commented Feb 28, 2025

Odd ... I'll add some tests and the package as well

@jkiddo
Copy link
Contributor Author

jkiddo commented Feb 28, 2025

@dotasek all three bullets should now be adressed.

@jkiddo jkiddo requested a review from dotasek February 28, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants