Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls_socket: remove secureConnection #3337

Merged
merged 2 commits into from
Apr 29, 2024
Merged

tls_socket: remove secureConnection #3337

merged 2 commits into from
Apr 29, 2024

Conversation

msimerson
Copy link
Member

@msimerson msimerson commented Apr 27, 2024

Changes proposed in this pull request:

  • logger: check Object.hasOwn to avoid circular deps
  • .gitignore: add config/me and config/*.pem
  • I tested this manually via sending (STARTTLS) and then client side via outbound and nothing blew up. What else should be tested?

Fixes #2743

Checklist:

- logger: check Object.hasOwn to avoid circular deps
- .gitignore: add config/me and config/*.pem
@msimerson msimerson merged commit 2b78d50 into master Apr 29, 2024
21 checks passed
@msimerson msimerson deleted the 2743-secureConnection branch April 29, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secureConnection event listener registration error
1 participant