dep(haraka-email-message): 1.2.3 -> 1.2.4 #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contribution process is just fine, the only nit is that since the other PR isn't merged, that version of email-message isn't yet published on NPM, so the tests here fail. |
msimerson
approved these changes
Sep 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes haraka/email-message#12.
Changes proposed in this pull request:
With this update, emails containing attachments named e.g. "[email protected]; [email protected]" won't be rejected anymore due to the combination of the filename being incorrectly read as "[email protected]" and the attachment Haraka plugin rejecting the com extension.
Checklist:
To the maintainer: I'm not entirely sure I'm following the right contribution process here (haraka/email-message#13 not being merged yet), feel free to discard this PR for another one if appropriate.