Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run rdns_access callback on connect hook #35

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

dalibor
Copy link
Contributor

@dalibor dalibor commented Nov 6, 2024

config/connect.rdns_access.blacklist config does not seem to work for blocking IPs because return codes from rdns_access function are ignored.

The connect_init hook is unique in that all return codes are ignored. This is so that plugins that need to do initialization for every connection can be assured they will run. Return values are ignored.

https://haraka.github.io/core/Plugins#connect_init

@dalibor dalibor changed the title Run rdns_access callback on connect hook (connect_init ignores return codes) Run rdns_access callback on connect hook Nov 6, 2024
@msimerson
Copy link
Member

Thanks @dalibor . This PR reverts #28

@msimerson msimerson merged commit cac57d2 into haraka:master Nov 6, 2024
8 checks passed
@msimerson msimerson mentioned this pull request Nov 6, 2024
msimerson added a commit that referenced this pull request Nov 6, 2024
- Run rdns_access callback on connect hook, #35
@dalibor dalibor deleted the rdns_access branch November 7, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants