Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CodeQL #820

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Enable CodeQL #820

merged 3 commits into from
Oct 3, 2023

Conversation

joycebrum
Copy link
Contributor

Closes #819

CodeQL success run https://github.com/joycebrum/TwelveMonkeys/actions/runs/6304188219
There were only a few (5) findings for the static analysis

I kept the comments but I can also remove them if you rather.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Signed-off-by: Joyce <[email protected]>
Copy link
Owner

@haraldk haraldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍🏻

As this project is very Java-centric, we might simplify things a bit, by removing the matrix and the support for Swift. But I guess it doesn't hurt, it's only about 30 lines of code. 😀

@haraldk haraldk merged commit 44bcd20 into haraldk:master Oct 3, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable a SAST Tool
2 participants