Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cluster output select dropdown should show meaningful sentence if no options available (backport #1270) #1272

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 4, 2025

Summary

Display the corresponding message if no matching options are found.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #7305

Occurred changes and/or fixed issues

Add condition this.isSearchable to function showTagPrompts

Areas or cases that should be tested

Go to Rancher
Go to Virtualization Management -> Harvester cluster -> Virtual Machines
Click on Console button

  • Go to Logging -> Cluster Flows
  • Click Create button and click second tab Outputs
  • Click the Cluster Outputs options, it should show Sorry, no matching options.
  • Same behavior to create Flows

Screenshot/Video

Screenshot 2025-01-20 at 1 35 49 PM (2)
Screenshot 2025-01-20 at 1 48 17 PM (2)


This is an automatic backport of pull request #1270 done by [Mergify](https://mergify.com).

@a110605
Copy link
Collaborator

a110605 commented Feb 4, 2025

Please rebase

@houhoucoop
Copy link

@mergify rebase

Signed-off-by: Yi-Ya Chen <[email protected]>
(cherry picked from commit 5099595)
Copy link
Author

mergify bot commented Feb 4, 2025

rebase

✅ Branch has been successfully rebased

@houhoucoop houhoucoop force-pushed the mergify/bp/release-harvester-v1.4/pr-1270 branch from 8aede87 to e0a5957 Compare February 4, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.4 Backport PR target v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants