Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embedded Rancher UI app charts page undefined error (POSTPONE to v1.4.3) #1279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Feb 25, 2025

Summary

A function name typo in previous migration commit

cf1caaa#diff-1f070e7bd7aa5deaccbf4007dc3b9f76cfc32066e9cf9b96caeb27bb1343b8bd

Undefined error happens in

 showCarousel() {
      return this.chartMode === 'featured' && this.getFeaturedCharts.length;
    }

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
harvester/harvester#7673 (comment)

Screenshot/Video

After fix

fixed_demo.mov

Copy link

@houhoucoop houhoucoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 changed the title Fix embedded Rancher UI app charts page undefined error Fix embedded Rancher UI app charts page undefined error (POSTPONE to v1.4.3) Feb 26, 2025
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants