Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Drone CI to build and push webhook #28

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Update Drone CI to build and push webhook #28

merged 1 commit into from
Jan 24, 2024

Conversation

connorkuehl
Copy link

@connorkuehl connorkuehl commented Jan 11, 2024

No description provided.

@connorkuehl connorkuehl marked this pull request as ready for review January 17, 2024 18:34
@connorkuehl connorkuehl marked this pull request as draft January 17, 2024 18:34
@connorkuehl
Copy link
Author

@bk201 @ibrokethecloud I think this should be reviewable but I'm still waiting on the Docker Hub repo so best not merge it if approved just yet.

@connorkuehl
Copy link
Author

Docker Hub repo is here 🎉 https://hub.docker.com/r/rancher/harvester-node-manager-webhook

@connorkuehl connorkuehl marked this pull request as ready for review January 18, 2024 15:06
Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@connorkuehl
Copy link
Author

@ibrokethecloud ping 🙂

Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@connorkuehl connorkuehl merged commit 2214b9f into harvester:master Jan 24, 2024
3 checks passed
@connorkuehl connorkuehl deleted the drone-webhook branch January 24, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants