ci: move from drone ci to github actions #44
Conversation
brandboat
force-pushed
the
HARV-5327
branch
2 times, most recently
from
e4e044b to
a402e39
Compare
|
Thanks @Yu-Jack, I've addressed the comments. Please take a look when you are available. |
scripts/package
Outdated
| if [ -e ${DOCKERFILE}.${ARCH} ]; then | ||
| DOCKERFILE=${DOCKERFILE}.${ARCH} | ||
| fi |
scripts/package-webhook
Outdated
| if [ -e ${DOCKERFILE}.${ARCH} ]; then | ||
| DOCKERFILE=${DOCKERFILE}.${ARCH} | ||
| fi |
| with: | ||
| secrets: | | ||
| secret/data/github/repo/${{ github.repository }}/dockerhub/rancher/credentials username | DOCKER_USERNAME ; | ||
| secret/data/github/repo/${{ github.repository }}/dockerhub/rancher/credentials password | DOCKER_PASSWORD |
There was a problem hiding this comment.
Not sure whether we need to change this like
https://github.com/harvester/terraform-provider-harvester/blob/4e07ed02cba6fe7fc37bc0d41ff433df81e69915/.github/workflows/build.yml#L58-L59.
We can merge it first and see whether we can get credential. Thanks.
There was a problem hiding this comment.
Not sure which one is right...
secret/data/github/repo/${{ github.repository }}/dockerhub/rancher/credentials or secret/data/github/repo/${{ github.repository }}/dockerhub/harvester/credentials
I saw some of repos like load-balancer-harvester, vm-import-controller use the former one.
Maybe both of them works.
There was a problem hiding this comment.
I asked this question before here https://github.com/rancherlabs/eio/issues/2153#issuecomment-2074150242. I think rancher is enough although I'm not sure why harvester works in https://github.com/harvester/terraform-provider-harvester.
There was a problem hiding this comment.
Got it. Thanks for the information.
|
@Mergifyio backport v0.1.x v0.2.x |
✅ Backports have been created
|
related to harvester/harvester#5327