Support new annotation behavior on storage network #1596
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Issue #1566
Why we need it
test_0_storage_network.py::test_storage_network
TestImageWithStorageNetwork::test_delete_image::teardown
TestVMWithStorageNetwork::test_enable_storage_network_with_api_stopped_vm::teardown
TestVMWithStorageNetwork::test_enable_storage_network_with_cli_stopped_vm::teardown
k8s.v1.cni.cncf.io/networks
but notk8s.v1.cni.cncf.io/network-status
. However we still need to check the latter for address.What this PR does
k8s.v1.cni.cncf.io/networks
annotation for storage-network enable/disable status.k8s.v1.cni.cncf.io/network-status
but only for address and name validation when enabling storage-network.Special notes for your reviewer
Validation
harvester-install-and-test/72
local ipxe-example
Additional documentation or context
n/a