Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vimeo fix #1900

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Vimeo fix #1900

wants to merge 16 commits into from

Conversation

djamg
Copy link
Contributor

@djamg djamg commented Oct 10, 2023

No description provided.

@djamg djamg requested review from vidya-ram and jace October 10, 2023 08:29
jace
jace requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@jace jace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we even have this client-side regex? It's fragile and needs multiple test cases.

funnel/assets/js/utils/embedvideo.js Outdated Show resolved Hide resolved
funnel/assets/js/utils/embedvideo.js Outdated Show resolved Hide resolved
@djamg djamg requested a review from jace October 17, 2023 19:29
vidya-ram
vidya-ram previously approved these changes Oct 25, 2023
View reviewed changes
@djamg djamg requested a review from vidya-ram December 5, 2023 06:57
jace
jace requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@jace jace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This regex is getting too complex and should be replaced with a URL parser. At the very least, it needs test cases.

funnel/assets/js/utils/embedvideo.js Outdated Show resolved Hide resolved
funnel/assets/js/utils/embedvideo.js Outdated Show resolved Hide resolved
funnel/forms/project.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jace jace jace requested changes

@vidya-ram vidya-ram Awaiting requested review from vidya-ram

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djamg @jace @vidya-ram