Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend test coverage on WHBAR contract #1265

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

natanasow
Copy link
Contributor

@natanasow natanasow commented Feb 27, 2025

Problem

Currently, we have 100% line coverage on WHBAR but that doesn't mean we've covered all of the business logic test cases.

Solution

Extend the current test plan.

https://limechain.notion.site/WHBAR-Test-Plan-1a610baa8dcd8062ad17d436fb5a1627?pvs=4

Related issue(s):

Fixes #1264

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
@natanasow natanasow added the enhancement New feature or request label Feb 27, 2025
@natanasow natanasow added this to the 0.12.0 milestone Feb 27, 2025
# Conflicts:
#	package-lock.json
#	test/wrapped-tokens/WHBAR.js
Copy link

github-actions bot commented Feb 27, 2025

Test Results

 18 files  ± 0  105 suites   - 1   20m 57s ⏱️ - 4m 22s
344 tests  - 11  322 ✅  - 11  16 💤  - 2  6 ❌ +2 
458 runs   - 15  434 ✅  - 15  18 💤  - 2  6 ❌ +2 

For more details on these failures, see this check.

Results for commit 511cca8. ± Comparison against base commit 49e709e.

This pull request removes 34 and adds 23 tests. Note that renamed tests count towards both.
"before all" hook for "should query allowance" ‑ TokenQueryContract Test Suite "before all" hook for "should query allowance"
"before all" hook for "should test that hollow account is created and the amount of fungible tokens is correctly transferred via system-contracts" ‑ HIP583 Test Suite - Ethereum Transfer TX via system-contracts Fungible Token Test "before all" hook for "should test that hollow account is created and the amount of fungible tokens is correctly transferred via system-contracts"
"before all" hook for "should test that hollow account is created and the amount of non-fungible tokens is correctly transferred via system-contracts" ‑ HIP583 Test Suite - Ethereum Transfer TX via system-contracts Non-Fungible Token Test "before all" hook for "should test that hollow account is created and the amount of non-fungible tokens is correctly transferred via system-contracts"
Should NOT allow a non-operator to transfer tokens to another account ‑ @OZERC1155Token Test Suite Should NOT allow a non-operator to transfer tokens to another account
Should allow an operator to transfer a token to another account ‑ @OZERC1155Token Test Suite Should allow an operator to transfer a token to another account
Should allow an operator to transfer tokens in batch to another account ‑ @OZERC1155Token Test Suite Should allow an operator to transfer tokens in batch to another account
should be able to update fixed HTS fee and royalty fee in NFT ‑ TokenManagmentContract Test Suite Update fees should be able to update fixed HTS fee and royalty fee in NFT
should be able to update fixed HTS fee for NFT ‑ TokenManagmentContract Test Suite Update fees should be able to update fixed HTS fee for NFT
should be able to update fixed fee for HBARs ‑ TokenManagmentContract Test Suite Update fees should be able to update fixed fee for HBARs
should be able to update fixed fee in HBARs for NFT ‑ TokenManagmentContract Test Suite Update fees should be able to update fixed fee in HBARs for NFT
…
"before each" hook for "Should allow an operator to transfer a token to another account" ‑ @OZERC1155Token Test Suite "before each" hook for "Should allow an operator to transfer a token to another account"
"before each" hook for "should be able to update fixed fee in HTS token" ‑ TokenManagmentContract Test Suite Update fees "before each" hook for "should be able to update fixed fee in HTS token"
should query allowance ‑ TokenQueryContract Test Suite should query allowance
should query getApproved ‑ TokenQueryContract Test Suite should query getApproved
should query getFungibleTokenInfo ‑ TokenQueryContract Test Suite should query getFungibleTokenInfo
should query getNonFungibleTokenInfo ‑ TokenQueryContract Test Suite should query getNonFungibleTokenInfo
should query getTokenCustomFees ‑ TokenQueryContract Test Suite should query getTokenCustomFees
should query getTokenDefaultFreezeStatus ‑ TokenQueryContract Test Suite should query getTokenDefaultFreezeStatus
should query getTokenDefaultKycStatus ‑ TokenQueryContract Test Suite should query getTokenDefaultKycStatus
should query getTokenExpiryInfo ‑ TokenQueryContract Test Suite should query getTokenExpiryInfo
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend test coverage on WHBAR contract
2 participants