Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: exposed multiple methods of ProtoParserTools and added unit test… #137

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

imalygin
Copy link
Member

@imalygin imalygin commented Dec 7, 2023

Exposed multiple methods of ProtoParserTools and added unit tests for them. Also, added readNextFieldNumber method

Related issue(s):

Fixes #74

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

github-actions bot commented Dec 7, 2023

JUnit Test Report

     47 files  +    1       47 suites  +1   3m 13s ⏱️ -24s
   875 tests +112     874 ✔️ +112    1 💤 ±0  0 ±0 
5 988 runs  +175  5 970 ✔️ +175  18 💤 ±0  0 ±0 

Results for commit b4075a8. ± Comparison against base commit 0f3d84e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

codacy-production bot commented Dec 7, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+4.73% (target: -1.00%) 74.12%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f2933b2) 6421 1318 20.53%
Head commit (b4075a8) 6430 (+9) 1624 (+306) 25.26% (+4.73%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#137) 85 63 74.12%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

github-actions bot commented Dec 7, 2023

Integration Test Report

     215 files  ±0       215 suites  ±0   6m 13s ⏱️ + 1m 57s
86 997 tests ±0  86 997 ✔️ ±0  0 💤 ±0  0 ±0 
87 263 runs  ±0  87 263 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit b4075a8. ± Comparison against base commit 0f3d84e.

♻️ This comment has been updated with latest results.

…s for them. Also, added `readNextFieldNumber` method

Signed-off-by: Ivan Malygin <[email protected]>
@imalygin imalygin force-pushed the 074-proto-parser-tools-methods branch from 901ca21 to 3b8f8ac Compare December 7, 2023 22:11
artemananiev
artemananiev previously approved these changes Dec 8, 2023
@imalygin imalygin force-pushed the 074-proto-parser-tools-methods branch from 5ef7c27 to ebd78ed Compare December 8, 2023 22:21
@imalygin imalygin force-pushed the 074-proto-parser-tools-methods branch from ebd78ed to b4075a8 Compare December 8, 2023 22:22
@imalygin imalygin merged commit d8ddc71 into main Dec 11, 2023
8 of 9 checks passed
@imalygin imalygin deleted the 074-proto-parser-tools-methods branch December 11, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some sizeOf methods aren't exposed publicly from ProtoWriterTools
2 participants