-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor auth methods red test selectors #2656
Merged
calcaide
merged 7 commits into
main
from
test-icu-15460-auth-method-read-test-selectors-refactor
Jan 24, 2025
Merged
Refactor auth methods red test selectors #2656
calcaide
merged 7 commits into
main
from
test-icu-15460-auth-method-read-test-selectors-refactor
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZedLi
previously approved these changes
Jan 21, 2025
Base automatically changed from
test-icu-15463-auth-method-list-test-selectors-refactor
to
main
January 22, 2025 22:32
calcaide
force-pushed
the
test-icu-15460-auth-method-read-test-selectors-refactor
branch
from
January 23, 2025 16:48
c987860
to
0f5e0c6
Compare
DhariniJeeva
previously approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
calcaide
dismissed
DhariniJeeva’s stale review
January 24, 2025 17:54
The merge-base changed after approval.
calcaide
force-pushed
the
test-icu-15460-auth-method-read-test-selectors-refactor
branch
from
January 24, 2025 20:01
b0fb502
to
7698e9d
Compare
DhariniJeeva
approved these changes
Jan 24, 2025
calcaide
deleted the
test-icu-15460-auth-method-read-test-selectors-refactor
branch
January 24, 2025 20:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update: the update test was merged from a previous reviewed branch
Refactor test selectors for read auth-methods acceptance test.
🎟️ Jira ticket
How to Test
$boundary-ui/ui/admin: yarn run test
.