Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor auth methods red test selectors #2656

Merged

Conversation

calcaide
Copy link
Collaborator

@calcaide calcaide commented Jan 10, 2025

Description

Update: the update test was merged from a previous reviewed branch

Refactor test selectors for read auth-methods acceptance test.

🎟️ Jira ticket

How to Test

  • Run unit tests successfully: $boundary-ui/ui/admin: yarn run test.

@calcaide calcaide self-assigned this Jan 10, 2025
@calcaide calcaide requested a review from a team as a code owner January 10, 2025 18:36
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 8:02pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 8:02pm

ZedLi
ZedLi previously approved these changes Jan 21, 2025
DhariniJeeva
DhariniJeeva previously approved these changes Jan 24, 2025
Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@calcaide calcaide dismissed DhariniJeeva’s stale review January 24, 2025 17:54

The merge-base changed after approval.

@calcaide calcaide merged commit 1e2134b into main Jan 24, 2025
12 checks passed
@calcaide calcaide deleted the test-icu-15460-auth-method-read-test-selectors-refactor branch January 24, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants