Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix HDS deprecation message #2661

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

calcaide
Copy link
Collaborator

Description

Fix HDS deprecation message for HDS Dropdown interactive component using @text rather than yielding it.

Screenshots:

Before:
Screenshot 2025-01-22 at 3 05 37 PM

After:
Screenshot 2025-01-22 at 3 05 51 PM

How to Test

  • Open the manage dropdown within a Credential store with the browser console open.
  • Run admin ui tests successfully.

Fix HDS deprecation message for HDS Dropdown interactive component using
@text rather than yielding it.
@calcaide calcaide self-assigned this Jan 22, 2025
@calcaide calcaide requested a review from a team as a code owner January 22, 2025 23:11
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 11:11pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 11:11pm

Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!!! Thx for the fix!

Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@calcaide calcaide merged commit 15950d3 into main Jan 23, 2025
13 checks passed
@calcaide calcaide deleted the fix-hds-deprecation-messasge branch January 23, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants