Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e/admin): Updates for 0.19.0 #2665

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test(e2e/admin): Updates for 0.19.0 #2665

wants to merge 3 commits into from

Conversation

moduli
Copy link
Collaborator

@moduli moduli commented Jan 24, 2025

Description

This PR updates the Admin UI e2e tests to account for some updates in Boundary 0.19.0.

  • updates the auth method "inactive" locator
  • updates locators due to the worker filter changes
  • fixes a flake in a test to make sure we want for the orgs page to load before clicking the auth methods link (since there's also an auth methods link on the global page)

How to Test

Run all Admin UI e2e tests

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

moduli added 3 commits January 24, 2025 10:16
@moduli
test(e2e): Update "Inactive" locators
7f3fff9
@moduli
test(e2e): Update worker filter locators
fd46877
@moduli
test(e2e): Address flake
0e89186 
Ensure that the test has reached the org page before trying to click the Auth Methods link (there is an auth method link on both the global page and the org page).
@vercel Vercel
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 8:20pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 8:20pm

@moduli moduli marked this pull request as ready for review January 24, 2025 20:21
@moduli moduli requested a review from a team as a code owner January 24, 2025 20:21
@moduli moduli requested a review from ZedLi January 24, 2025 20:21
@moduli moduli changed the title test(e2e/admin): Update for 0.19.0 test(e2e/admin): Updates for 0.19.0 Jan 24, 2025
DhariniJeeva
DhariniJeeva approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thank you for fixing these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronperera cameronperera cameronperera approved these changes

@DhariniJeeva DhariniJeeva DhariniJeeva approved these changes

@ZedLi ZedLi ZedLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moduli @ZedLi @DhariniJeeva @cameronperera