test(grants): tests for group associations #5443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkanney
force-pushed
the
dkanney-test-grants-for-user-group-associations
branch
2 times, most recently
from
9d2f5c3 to
6bdc21d
Compare
dkanney
force-pushed
the
dkanney-test-grants-for-user-group-associations
branch
from
6bdc21d to
34114df
Compare
elimt
reviewed
Jan 23, 2025
| repo := iam.TestRepo(t, conn, wrap) | ||
| kmsCache := kms.TestKms(t, conn, wrap) | ||
|
|
||
| grant := "ids=*;type=*;actions=*" |
There was a problem hiding this comment.
For the grant, if we're testing against the groups resource, we should set set the grant to look like ids=*;type=group;actions=*.
There was a problem hiding this comment.
I also think we should have multiple grants and multiple roles so we can have multiple grantTuples and assert it's what we expect
elimt
reviewed
Jan 24, 2025
| res: perms.Resource{ | ||
| ScopeId: directGrantProj1a.PublicId, | ||
| Id: "cs_abcd1234", | ||
| Type: resource.Credential, |
There was a problem hiding this comment.
Do we hae dedicated tests for Groups resource
dkanney
force-pushed
the
dkanney-test-grants-for-user-group-associations
branch
from
34114df to
79b9462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.