feat: add grants tests for alias #5550
Open
+1,177
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
requested changes
Feb 19, 2025
elimt
requested review from
johanbrandhorst,
mgaffney,
bosorawis and
dkanney
johanbrandhorst
approved these changes
Feb 19, 2025
bosorawis
reviewed
Feb 19, 2025
| userFunc: iam.TestUserGroupGrantsFunc(t, conn, kmsCache, globals.GlobalPrefix, password.TestAccountFunc(t, conn), []iam.TestRoleGrantsRequest{ | ||
| { | ||
| RoleScopeID: globals.GlobalPrefix, | ||
| Grants: []string{"id=*;type=alias;actions=*"}, |
There was a problem hiding this comment.
could you add a test case that scopes down id, type, and actions as well?
There was a problem hiding this comment.
just added some test cases for that
bosorawis
approved these changes
Feb 19, 2025
add test coverage for testing grants with alias resource. This tests all actions with aliases and different grant scopes
elimt
force-pushed
the
elimt-alias-grants-test
branch
from
ad0dabf to
d7cebeb
Compare
bosorawis
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test coverage for testing grants with alias resource. This tests all actions with aliases and different grant scopes