-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prebuild script for building sitemaps for builds #2664
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action π€ This PR introduced no changes to the javascript bundle π |
Update: After some feedback in the Asana task, I changed this PR so that the build sitemap script is run on the prebuild step instead of having it run as a separate github action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for this work! β€οΈ
π Relevant links
ποΈ What
This PR adds a prebuild script that runs on the build step to determine if the docs and tutorials sitemaps are generated successfully. I also had to edit the
allDocsFields
andallTutorialsFields
functions to take config as an argument since the script does not have access to the config when it is being runπ€· Why
With the migration to UDR coming up over the next few months, this check makes sure the sitemaps are working properly to catch any errors we may have with the migration.
π§ͺ Testing