Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validated-patterns content #2666

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Add validated-patterns content #2666

merged 9 commits into from
Jan 17, 2025

Conversation

im2nguyen
Copy link
Contributor

@im2nguyen im2nguyen commented Jan 16, 2025 •
edited
Loading

🔗 Relevant links

🗒️ What

This PR temporarily creates an empty validated-patterns landing page so we can preview the changes in the tutorials repo.

🤷 Why

🛠️ How

I used well-architected-framework as a template for validated-patterns. We'll add validated-patterns to the product dropdown when the content is ready in tutorials.

📸 Design Screenshots

🧪 Testing

💭 Anything else?

@im2nguyen im2nguyen requested a review from a team as a code owner January 16, 2025 16:02
@im2nguyen im2nguyen requested review from acidprime and stellarsquall and removed request for a team January 16, 2025 16:02
@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 11:04pm

@im2nguyen im2nguyen requested review from heatlikeheatwave, a team and emilypersson1 and removed request for acidprime and stellarsquall January 16, 2025 16:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load
/validated-patterns 149.81 KB 344.45 KB
/validated-patterns/[...tutorialSlug] 191.78 KB 386.42 KB
/validated-patterns/[collectionSlug] 137.96 KB 332.6 KB

emilypersson1
emilypersson1 approved these changes Jan 17, 2025
View reviewed changes
Copy link

@emilypersson1 emilypersson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

heatlikeheatwave
heatlikeheatwave requested changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@heatlikeheatwave heatlikeheatwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add { return notFound: true } to the files you added in the pages dir. That way, it won't surface in production and it won't try to fetch tutorials that don't yet exist.

src/pages/validated-patterns/[collectionSlug].tsx Outdated Show resolved Hide resolved
src/pages/validated-patterns/index.tsx Outdated Show resolved Hide resolved
src/pages/validated-patterns/[...tutorialSlug]/index.tsx Show resolved Hide resolved
@im2nguyen im2nguyen changed the title Add validated-patterns content (placeholder) Add validated-patterns content Jan 17, 2025
@im2nguyen im2nguyen merged commit e913afc into main Jan 17, 2025
9 checks passed
@im2nguyen im2nguyen deleted the add-validated-patterns-placeholder branch January 17, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heatlikeheatwave heatlikeheatwave heatlikeheatwave approved these changes

@emilypersson1 emilypersson1 emilypersson1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@im2nguyen @heatlikeheatwave @emilypersson1