feat: add hvd-docs redirects functionality #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LeahMarieBush
commented
Jan 21, 2025
build-libs/redirects.js
Outdated
| // hvd-docs is not hosted on the content API, so we need to use main as the latest sha | ||
| const latestContentSha = | ||
| repoName === 'hvd-docs' | ||
| ? 'daf97dfd494470e27acf2b74a95919ac748a54f6' |
There was a problem hiding this comment.
TODO before merge: change this SHA to 'main'. Currently this a sha from a commit I made in the hvd-docs repo that is used to test this PR
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
LeahMarieBush
requested review from
a team,
rmainwork and
RubenSandwich
and removed request for
a team
rmainwork
reviewed
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Relevant links
🗒️ What
This PR adds redirects functionality for hvd-docs. It works the same way as other product redirects in dev-portal.
🤷 Why
There is not currently redirect support for hvd-docs. That team has requested the functionality (see Slack thread)
🧪 Testing
/validated-designshomepage💭 Anything else?
The PR has a sha value for the hvd-docs repo that is just for testing. The sha links to a commit that I created on the hvd-docs repo to add an example redirect for testing (See this commit) After PR has been tested by a reviewer, I will change that back to 'main' before merging. See PR comment for more info.