-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove boundary installer for versions less than 0.18.0 #2678
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action π€ Twelve Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
I think this increase is due to adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
π Relevant links
ποΈ What
This PR removes the 'Boundary Installer' section on the boundary install page for versions less that 0.18.0
π€· Why
Boundary versions before 0.18.0 don't work with the installer so the boundary team requested that we remove this section for those versions.
π οΈ How
I used the
useCurrentVersion
hook to get the current version and usedsemver
to compare that with version 0.18.0 to see if it was a lesser version. Using that value I conditionally rendered the 'Boundary Installer' section on the page and removed the 'Boundary Installer' section from the sidebar.In order to use the
useCurrentVersion
hook, I had to use it in components that are wrapped in theCurrentVersionProvider
component. Ideally, I would have liked to put my changes in thesrc/views/product-downloads-view/boundary/index.tsx
file, but since it is not wrapped in theCurrentVersionProvider
, I had to add this logic to other components. I'm open to other ideas of how to accomplish this if you have any!πΈ Design Screenshots
Screen.Recording.2025-01-23.at.3.29.21.PM.mov
π§ͺ Testing