-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add packer nightly formula #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sylviamoss, I think this PR should include an update to util/formula_templater/config.hcl
to add a template for packer-nightly but I’m not 100% if that supports conflicts_with
and/or version "nightly"
.. I'll requests a review from @kpenfound as I think he will be in a better position to help with this hopefully!
Got it! Thank you @samsalisbury |
def install | ||
bin.install "packer" | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be a possibility and a good idea to rename the binary to packer-nightly
here ? 🤔
Just to add some context here, Homebrew unfortunately doesn't have any decent/clean way of supporting multiple versions and we have in the past avoided adding these - see also #79 That said I'm certainly not in a position to say this is still a current stance and that it applies specifically to nightly releases, I'm merely adding the context. If you are going ahead with this as a separate formula I would suggest change the class name to something unique - e.g. Secondly you may want to consider making the The As for the binary name - I don't have too strong opinion on this, but it seems that the convention in the wild is to retain the name used for all other versions as opposed to adding the version there. See also https://github.com/Homebrew/linuxbrew-core/blob/HEAD/Formula/[email protected] for inspiration. |
Thanks @radeksimko for the context. Know that I decided not to move forward with this. It makes sense to download non-stable nightly releases only from GitHub and making it explicit about it. |
This adds the packer nightly releases. The nightly releases are updated every 7 days.
I haven't tested the formula and would like some help with it.