Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPC modifications to include the lock work #17697

Merged
merged 55 commits into from
Jul 31, 2023
Merged

Commits on Jul 27, 2023

  1. Configuration menu
    Copy the full SHA
    16cd69d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa0543d View commit details
    Browse the repository at this point in the history
  3. Delete lock.go

    Juanadelacuesta committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    a6bbaaf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8ad7bbd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c8cbec7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a8c2aad View commit details
    Browse the repository at this point in the history
  7. fix: sync msg types

    Juanadelacuesta committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d5af7a0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f40bc7a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a58e815 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3441ae6 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2b285eb View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3a46135 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    582d67d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    4696bd0 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    11685ac View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    7a6a091 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    94484c6 View commit details
    Browse the repository at this point in the history
  18. fix: adjust the look up for query params to only be done on put and p…

    …osts to simplify the logic
    Juanadelacuesta committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    7bf5014 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    f068f17 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    90fb2a4 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    439b77e View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    c829e2b View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    379d6ee View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    2a63039 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    f60991c View commit details
    Browse the repository at this point in the history
  26. Update nomad/fsm.go

    Co-authored-by: Tim Gross <[email protected]>
    Juanadelacuesta and tgross committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e09d32f View commit details
    Browse the repository at this point in the history
  27. func: change the return when lock ID is wrong from error to conflict

    Also hide the variable items
    Juanadelacuesta committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    997f7dd View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    5e29ff9 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    e4353fd View commit details
    Browse the repository at this point in the history
  30. fix: separate the table update for the lock release, the var update c…

    …ant be used because of the missing lock ID
    Juanadelacuesta committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1b36b06 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    6253296 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    5c3b8a3 View commit details
    Browse the repository at this point in the history
  33. func: allow for users to overide the variable data when locking, the …

    …responsibility is left for teh user
    Juanadelacuesta committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    0d6d59a View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    1fb2643 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    7747fd5 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    070d489 View commit details
    Browse the repository at this point in the history
  37. Add acquire and release lock functions on the state store (#17794)

    * fix: move the rpc metrics up on the renew lock to include auth errors
    
    * func: add acquire and release lock functions on fsm
    
    * func: fix the query for missing lock to avoid nil points in case of a missing lock
    
    * func: add happy path test for acquire and release flows on non existing variable
    
    * fix: solve rebase with rpc conflicts
    
    * func: add testing for release lock
    
    * style: typo
    
    * fix: remove debug file
    
    * Update nomad/fsm.go
    
    Co-authored-by: Tim Gross <[email protected]>
    
    * func: change the return when lock ID is wrong from error to conflict
    Also hide the variable items
    
    * func: add lock ID verification for variable upserts
    
    * fix: check for empty lock instead of empty lock ID on setCas to avoid nil pointer
    
    * fix: separate the table update for the lock release, the var update cant be used because of the missing lock ID
    
    * func: add tests for delete CAS with lock ID check
    
    * func: move lock ID check to the inner most tx function, not the CAS wrappers
    
    * fix: add lock not nil check on release to avoid nill pointers
    
    * style: function rename
    
    * func: remove the lock ID check from the CAS delete
    
    * func: allow for users to overide the variable data when locking, the responsibility is left for teh user
    
    ---------
    
    Co-authored-by: Tim Gross <[email protected]>
    Juanadelacuesta and tgross committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    22c1fee View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    103a8f4 View commit details
    Browse the repository at this point in the history
  39. fix: add a restriction for CAS and lock, only one at the time and avo…

    …id overwriting data when lock release
    Juanadelacuesta committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d7e7149 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    c471356 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    e7277f1 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    c3e10f3 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    83d9d7d View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    6440af0 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    c769d5b View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Configuration menu
    Copy the full SHA
    276b9f5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8124801 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    950749a View commit details
    Browse the repository at this point in the history
  4. style: typo

    Juanadelacuesta committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    ef7cffe View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    35b309a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8496b6d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6c0eab9 View commit details
    Browse the repository at this point in the history
  4. Update nomad/variables_endpoint.go

    Co-authored-by: Tim Gross <[email protected]>
    Juanadelacuesta and tgross authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    dfd9507 View commit details
    Browse the repository at this point in the history
  5. Update nomad/variables_endpoint.go

    Co-authored-by: Tim Gross <[email protected]>
    Juanadelacuesta and tgross authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    dfc61ad View commit details
    Browse the repository at this point in the history
  6. fix: typo

    Juanadelacuesta committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    d46dd2a View commit details
    Browse the repository at this point in the history