Backport of chore(nodepool): Go stdlib vars for HTTP methods and status codes into release/1.6.x #18065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/chore/usestdlibvars-nodepool/moderately-enjoyed-akita
branch
from
eb77494
to
4fedbbb
Compare
hc-github-team-nomad-core
deleted the
backport/chore/usestdlibvars-nodepool/moderately-enjoyed-akita
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18061 to be assessed for backporting due to the inclusion of the label backport/1.6.x.
The below text is copied from the body of the original PR.
Split node pool related changes from #17968 to a separate PR. Makes backporting these changes easier.
What
net/httprelated calls to consistently use HTTP methods and response codes from variables/constants provided by the pkg.Why
Some parts of the codebase already use these. With this PR, better code consistency and reliability.