Backport of chore(lint): use Go stdlib variables for HTTP methods and status codes into release/1.4.x #18072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/chore/usestdlibvars/hideously-darling-insect
branch
from
2637857
to
ea689f7
Compare
hc-github-team-nomad-core
force-pushed
the
backport/chore/usestdlibvars/hideously-darling-insect
branch
from
ea689f7
to
2637857
Compare
|
|
jrasell
force-pushed
the
backport/chore/usestdlibvars/hideously-darling-insect
branch
from
a55aac8
to
64b1c77
Compare
jrasell
deleted the
backport/chore/usestdlibvars/hideously-darling-insect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17968 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
What
net/httprelated calls to consistently use HTTP methods and response codes from variables/constants provided by the pkg.usestdlibvarsto lint configuration.See #18061 and #18062 for changes related to node pool and variable endpoints.
Why
Some parts of the codebase already use these. With this PR, better code consistency and reliability.