Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Pin body-parser to resolve an outdated dep #23954

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[ui] Pin body-parser to resolve an outdated dep #23954

merged 1 commit into from
Sep 13, 2024

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud self-assigned this Sep 13, 2024
@philrenaud philrenaud added backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line backport/1.8.x backport to 1.8.x release line labels Sep 13, 2024
tgross
tgross approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note you want to backport to 1.6.x+ent, 1.7.x+ent, and 1.8.x (which gets merged to 1.8.x+ent). Not CE for 1.6 and 1.7

@philrenaud philrenaud added backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent and removed backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line labels Sep 13, 2024
@github-actions GitHub Actions
Copy link

Ember Test Audit comparison

main 6fed7d6651e20e5ccd8581a1d0b083af7f07dbfb change
passes 1578 1578 0
failures 0 0 0
flaky 0 0 0
duration 11m 37s 614ms 11m 54s 875ms +17s 261ms

@philrenaud philrenaud merged commit 51caca1 into main Sep 13, 2024
8 of 13 checks passed
@philrenaud philrenaud deleted the b-ui/pin-body-parser branch September 13, 2024 17:59
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Sep 13, 2024
Closed
philrenaud added a commit that referenced this pull request Sep 14, 2024
@philrenaud
Pin body-parser to resolve an outdated dep problem (#23954)
05bdcbe
@philrenaud philrenaud mentioned this pull request Sep 14, 2024
Closed
philrenaud added a commit that referenced this pull request Sep 16, 2024
@philrenaud
Revert "Pin body-parser to resolve an outdated dep problem (#23954)"
6652d35 
This reverts commit 51caca1.
philrenaud added a commit that referenced this pull request Sep 16, 2024
@philrenaud
Revert "Pin body-parser to resolve an outdated dep problem (#23954)" (#…
4835068 
…23970)

This reverts commit 51caca1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduzgun-security dduzgun-security dduzgun-security approved these changes

@tgross tgross tgross approved these changes

@Juanadelacuesta Juanadelacuesta Awaiting requested review from Juanadelacuesta

Assignees

@philrenaud philrenaud

Labels
backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/1.8.x backport to 1.8.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philrenaud @tgross @dduzgun-security