Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Golden Versions #24055

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Feature: Golden Versions #24055

merged 5 commits into from
Sep 25, 2024

Commits on Sep 24, 2024

  1. TaggedVersion information in structs, rather than job_endpoint (#23841)

    * TaggedVersion information in structs, rather than job_endpoint
    
    * Test for taggedVersion description length
    
    * Some API plumbing
    philrenaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a5a02e7 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Tag and Untag job versions (#23863)

    * Tag and Untag at API level on down, but am I unblocking the wrong thing?
    
    * Code and comment cleanup
    
    * Unset methods generally now I stare long into the namespace abyss
    
    * Namespace passes through with QueryOptions removed from a write requesting struct
    
    * Comment and PR review cleanup
    
    * Version back to VersionStr
    
    * Generally consolidate unset logic into apply for version tagging
    
    * Addressed some PR comments
    
    * Auth check and RPC forwarding
    
    * uint64 instead of pointer for job version after api layer and renamed copy
    
    * job tag command split into apply and unset
    
    * latest-version convenience handling moved to CLI command level
    
    * CLI tests for tagging/untagging
    
    * UI parts removed
    
    * Add to job table when unsetting job tag on latest version
    
    * Vestigial no more
    
    * Compare versions by name and version number with the nomad history command (#23889)
    
    * First pass at passing a tagname and/or diff version to plan/versions requests
    
    * versions API now takes compare_to flags
    
    * Job history command output can have tag names and descriptions
    
    * compare_to to diff-tag and diff-version, plus adding flags to history command
    
    * 0th version now shows a diff if a specific diff target is requested
    
    * Addressing some PR comments
    
    * Simplify the diff-appending part of jobVersions and hide None-type diffs from CLI
    
    * Remove the diff-tag and diff-version parts of nomad job plan, with an eye toward making them a new top-level CLI command soon
    
    * Version diff tests
    
    * re-implement JobVersionByTagName
    
    * Test mods and simplification
    
    * Documentation for nomad job history additions
    
    * Prevent pruning and reaping of TaggedVersion jobs (#23983)
    
    tagged versions should not count against JobTrackedVersions
    i.e. new job versions being inserted should not evict tagged versions
    
    and GC should not delete a job if any of its versions are tagged
    
    Co-authored-by: Daniel Bennett <[email protected]>
    
    ---------
    
    Co-authored-by: Daniel Bennett <[email protected]>
    
    * [ui] Version Tags on the job versions page (#24013)
    
    * Timeline styles and their buttons modernized, and tags added
    
    * styled but not yet functional version blocks
    
    * Rough pass at edit/unedit UX
    
    * Styles consolidated
    
    * better UX around version tag crud, plus adapter and serializers
    
    * Mirage and acceptance tests
    
    * Modify percy to not show time-based things
    
    ---------
    
    Co-authored-by: Daniel Bennett <[email protected]>
    philrenaud and gulducat authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f13273e View commit details
    Browse the repository at this point in the history
  2. Job revert command and API endpoint can take a string version tag name (

    #24059)
    
    * Job revert command and API endpoint can take a string version tag name
    
    * RevertOpts as a signature-modified alternative to Revert()
    
    * job revert CLI test
    
    * Version pointers in endpoint tests
    
    * Dont copy over the tag when a job is reverted to a version with a tag
    
    * Convert tag name to version number at CLI level
    
    * Client method for version lookup by tag
    
    * No longer double-declaring client
    philrenaud authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    cd3f47c View commit details
    Browse the repository at this point in the history
  3. [ui] Add tag filter to the job versions page (#24064)

    * Rough pass at the UI for version diff dropdown
    
    * Cleanup and diff fetching via adapter method
    philrenaud authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    282db55 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a750d71 View commit details
    Browse the repository at this point in the history