Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Remove ember-fetch dependency #24077

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

philrenaud
Copy link
Contributor

Resolves #24076

Copy link

github-actions bot commented Sep 27, 2024

Ember Test Audit comparison

main 0f5594c change
passes 1581 1254 -327
failures 0 182 +182
flaky 0 0 0
duration 11m 53s 574ms 000ms -11m 53s 574ms

assert.ok(Allocation.stop.isDisabled, 'Stop is disabled');
assert.ok(Allocation.restart.isDisabled, 'Restart is disabled');
assert.ok(Allocation.restartAll.isDisabled, 'Restart All is disabled');
server.pretender.resolve(server.pretender.requestReferences[0].request);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: with the changes here, requestReferences was always [] during this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - DOM Clobbering Gadget found in rollup bundled scripts that leads to XSS
1 participant